Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements to chapter 18 (A Simple Contact Book) #63

Merged
merged 1 commit into from
Apr 16, 2024
Merged

Improvements to chapter 18 (A Simple Contact Book) #63

merged 1 commit into from
Apr 16, 2024

Conversation

koendehondt
Copy link
Collaborator

@koendehondt koendehondt commented Apr 16, 2024 •
edited
Loading

  • Dropped Eg prefix of classes and packages, because the diagram under "Contact book model" does not include those prefixes.
  • Added ContacnBook>>contents because it was missing but referenced under "Widget initialization".
  • Replaced defaultSpec by defaultLayout.
  • Adapted methods according to our guidelines (empty line after selector).
  • Some text improvements here and there.

Open issue

  • The diagram under "Contact book model" shows findContact, but the text includes ContactBook >> findContactsWithText:. The diagram has to be adapted.

@Ducasse
Copy link
Member

Ducasse commented Apr 16, 2024

Sound good.

@Ducasse Ducasse merged commit de71382 into master Apr 16, 2024
1 check passed
This was referenced Apr 19, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ducasse Ducasse Awaiting requested review from Ducasse

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@koendehondt @Ducasse